From efc4e96221a6ffa6dbb2da2977e230bf06593a5b Mon Sep 17 00:00:00 2001 From: Ramakrishna Pattnaik Date: Thu, 19 Aug 2021 16:56:23 +0530 Subject: [PATCH] fix: address review comments --- pkg/cmd/kafka/consumergroup/describe/describe.go | 6 +++--- pkg/kafka/consumergroup/util.go | 6 +++--- .../locales/en/cmd/kafka_consumergroup_describe.en.toml | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pkg/cmd/kafka/consumergroup/describe/describe.go b/pkg/cmd/kafka/consumergroup/describe/describe.go index 3f5290245..138b365c7 100644 --- a/pkg/cmd/kafka/consumergroup/describe/describe.go +++ b/pkg/cmd/kafka/consumergroup/describe/describe.go @@ -168,7 +168,7 @@ func mapConsumerGroupDescribeToTableFormat(consumers []kafkainstanceclient.Consu } if consumer.GetMemberId() == "" { - row.MemberID = color.Italic("unconsumed") + row.MemberID = color.Italic("unassigned") } rows = append(rows, row) @@ -189,9 +189,9 @@ func printConsumerGroupDetails(w io.Writer, consumerGroupData kafkainstanceclien activeMembersCount := cgutil.GetActiveConsumersCount(consumers) partitionsWithLagCount := cgutil.GetPartitionsWithLag(consumers) - unconsumedPartitions := cgutil.GetUnconsumedPartitions(consumers) + unassignedPartitions := cgutil.GetUnassignedPartitions(consumers) - fmt.Fprintln(w, color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.activeMembers")), activeMembersCount, "\t", color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.partitionsWithLag")), partitionsWithLagCount, "\t", color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.unconsumedPartitions")), unconsumedPartitions) + fmt.Fprintln(w, color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.activeMembers")), activeMembersCount, "\t", color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.partitionsWithLag")), partitionsWithLagCount, "\t", color.Bold(localizer.MustLocalize("kafka.consumerGroup.describe.output.unassignedPartitions")), unassignedPartitions) fmt.Fprintln(w, "") rows := mapConsumerGroupDescribeToTableFormat(consumers) diff --git a/pkg/kafka/consumergroup/util.go b/pkg/kafka/consumergroup/util.go index 3bb28f98b..f6df3eb38 100644 --- a/pkg/kafka/consumergroup/util.go +++ b/pkg/kafka/consumergroup/util.go @@ -24,11 +24,11 @@ func GetActiveConsumersCount(consumers []kafkainstanceclient.Consumer) (count in return count } -func GetUnconsumedPartitions(consumers []kafkainstanceclient.Consumer) (unconsumedPartitions int) { +func GetUnassignedPartitions(consumers []kafkainstanceclient.Consumer) (unassignedPartitions int) { for _, c := range consumers { if c.GetMemberId() == "" { - unconsumedPartitions++ + unassignedPartitions++ } } - return unconsumedPartitions + return unassignedPartitions } diff --git a/pkg/localize/locales/en/cmd/kafka_consumergroup_describe.en.toml b/pkg/localize/locales/en/cmd/kafka_consumergroup_describe.en.toml index 11ce65324..9ecee2105 100644 --- a/pkg/localize/locales/en/cmd/kafka_consumergroup_describe.en.toml +++ b/pkg/localize/locales/en/cmd/kafka_consumergroup_describe.en.toml @@ -27,5 +27,5 @@ one = 'ACTIVE MEMBERS:' [kafka.consumerGroup.describe.output.partitionsWithLag] one = 'PARTITIONS WITH LAG:' -[kafka.consumerGroup.describe.output.unconsumedPartitions] -one = 'UNCONSUMED PARTITIONS:' \ No newline at end of file +[kafka.consumerGroup.describe.output.unassignedPartitions] +one = 'UNASSIGNED PARTITIONS:' \ No newline at end of file