From 5b59c350e9b9c169c02928d63b42c69c5bee447a Mon Sep 17 00:00:00 2001 From: Ramakrishna Pattnaik Date: Mon, 24 May 2021 18:21:24 +0530 Subject: [PATCH] fix: erroneous message for invalid option --- pkg/cmd/flag/flag.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/flag/flag.go b/pkg/cmd/flag/flag.go index c9f2e21d0..dba832208 100644 --- a/pkg/cmd/flag/flag.go +++ b/pkg/cmd/flag/flag.go @@ -20,7 +20,7 @@ func (e *Error) Unwrap() error { func InvalidValueError(flag string, val interface{}, validOptions ...string) *Error { var chooseFromStr string if len(validOptions) > 0 { - chooseFromStr = ", valid options are: '" + chooseFromStr = ", valid options are: " for i, option := range validOptions { chooseFromStr += fmt.Sprintf(`"%v"`, option) if (i + 1) < len(validOptions) { @@ -28,7 +28,7 @@ func InvalidValueError(flag string, val interface{}, validOptions ...string) *Er } } } - return &Error{Err: fmt.Errorf(`invalid value "%v" for --%v%v`, flag, val, chooseFromStr)} + return &Error{Err: fmt.Errorf(`invalid value "%v" for --%v%v`, val, flag, chooseFromStr)} } func RequiredWhenNonInteractiveError(arg string) error {