Skip to content

fix: add name to confirmation dialog on delete#987

Merged
wtrocki merged 2 commits intomainfrom
name-add
Aug 30, 2021
Merged

fix: add name to confirmation dialog on delete#987
wtrocki merged 2 commits intomainfrom
name-add

Conversation

@wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Aug 30, 2021 •
edited
Loading

Before

 rhoas kafka delete
? Confirm the name of the instance you want to delete: wtrocki

After

 rhoas kafka delete
? Confirm the name of the instance you want to delete (wtrocki) wtrocki

@wtrocki
Copy link
Collaborator Author

wtrocki commented Aug 30, 2021

Blocked by #982

craicoverflow
craicoverflow approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@craicoverflow craicoverflow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a fix. It is a new feature, nothing is broken.

I don't think that #982 blocks this.

@craicoverflow
Copy link
Contributor

craicoverflow commented Aug 30, 2021

Good addition 👍🏻

@wtrocki wtrocki merged commit 14862d1 into main Aug 30, 2021
@wtrocki wtrocki deleted the name-add branch August 30, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@craicoverflow craicoverflow craicoverflow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wtrocki @craicoverflow