feat(kafka): add --wait flag to perform synchronous Kafka creation#960
Merged
craicoverflow merged 4 commits intomainfrom Aug 24, 2021
Merged
feat(kafka): add --wait flag to perform synchronous Kafka creation#960craicoverflow merged 4 commits intomainfrom
craicoverflow merged 4 commits intomainfrom
Conversation
wtrocki
reviewed
Aug 24, 2021
wtrocki
reviewed
Aug 24, 2021
| } | ||
|
|
||
| // NewSpinner returns a new spinner progress bar to be used in synchronous commands | ||
| func (s *IOStreams) NewSpinner() *spinner.Spinner { |
wtrocki
reviewed
Aug 24, 2021
pkg/cmd/kafka/create/create.go
Outdated
|
|
||
| for svcstatus.IsCreating(response.GetStatus()) { | ||
| time.Sleep(cmdutil.DefaultPollTime) | ||
| s.Suffix = " " + opts.localizer.MustLocalize("kafka.create.log.info.creationInProgress", localize.NewEntry("Name", response.GetName()), localize.NewEntry("Status", color.Info(response.GetStatus()))) |
Collaborator
There was a problem hiding this comment.
Suggested change
| s.Suffix = " " + opts.localizer.MustLocalize("kafka.create.log.info.creationInProgress", localize.NewEntry("Name", response.GetName()), localize.NewEntry("Status", color.Info(response.GetStatus()))) | |
| s.Suffix = " " + opts.localizer.MustLocalize("kafka.create.log.info.creationInProgress", | |
| localize.NewEntry("Name", response.GetName()), | |
| localize.NewEntry("Status", color.Info(response.GetStatus()))) |
wtrocki
reviewed
Aug 24, 2021
pkg/cmd/kafka/create/create.go
Outdated
Comment on lines
+228
to
+229
| logger.Info() | ||
| logger.Info() |
Collaborator
There was a problem hiding this comment.
Suggested change
| logger.Info() | |
| logger.Info() | |
| logger.Info("\n\n") |
bhardesty
reviewed
Aug 24, 2021
| one = 'Set the new Kafka instance to the current instance' | ||
|
|
||
| [kafka.create.flag.wait.description] | ||
| one = 'Wait for the Kafka instance to finish creating' |
Contributor
There was a problem hiding this comment.
Suggested change
| one = 'Wait for the Kafka instance to finish creating' | |
| one = 'Wait until the Kafka instance is created' |
Contributor
There was a problem hiding this comment.
Should we put a message if user cancels creation with Ctrl +C. It should imply that creation is still going on (and not cancelled) and user can check status.
Based on intuition, I would expect the create operation to be entirely cancelled if I do a Ctrl +C, what do you think?
Contributor
Author
Yeah I like that. Will look into it. |
wtrocki
approved these changes
Aug 24, 2021
Contributor
Author
|
I have added logic to detect a SIGINT and shows an appropriate message. Mind checking that? |
rkpattnaik780
approved these changes
Aug 24, 2021
Contributor
rkpattnaik780
left a comment
rkpattnaik780
left a comment
There was a problem hiding this comment.
Looks great! Just a typo.
craicoverflow
force-pushed
the
sync-create
branch
from
6ae5f04 to
1d4f25d
Compare
craicoverflow
force-pushed
the
sync-create
branch
from
1d4f25d to
3d5b59a
Compare
craicoverflow
changed the title
craicoverflow
pushed a commit
that referenced
this pull request
Aug 24, 2021
craicoverflow
pushed a commit
that referenced
this pull request
Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #604
Verification Steps
rhoas kafka create my-kafka -wType of change
Checklist