Skip to content

fix(login): use mas-sso host in login success message#889

Merged
craicoverflow merged 1 commit intoredhat-developer:mainfrom
craicoverflow:use-mas-host-in-msg
Aug 11, 2021
Merged

fix(login): use mas-sso host in login success message#889
craicoverflow merged 1 commit intoredhat-developer:mainfrom
craicoverflow:use-mas-host-in-msg

Conversation

@craicoverflow
Copy link
Contributor

@craicoverflow craicoverflow commented Aug 11, 2021

Closes #886

Verification Steps

  1. Log in to MAS-SSO staging: rhoas login --mas-auth-url=stg
  2. Note the success message on the redirect URL and terminal output. They should both reflect that MAS-SSO URL.
❯ ./rhoas login --mas-auth-url stg
Logging in...

Logged in successfully
Logging in to identity.api.stage.openshift.com...

Logged in successfully to identity.api.stage.openshift.com

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@craicoverflow craicoverflow requested review from rkpattnaik780 and wtrocki and removed request for wtrocki August 11, 2021 09:50
rkpattnaik780
rkpattnaik780 approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@rkpattnaik780 rkpattnaik780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@craicoverflow craicoverflow merged commit b4128d5 into redhat-developer:main Aug 11, 2021
@craicoverflow craicoverflow deleted the use-mas-host-in-msg branch August 11, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkpattnaik780 rkpattnaik780 rkpattnaik780 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When logging in to staging, success message should be "Logged in successfully to identity.api.stage.openshift.com"

2 participants

@craicoverflow @rkpattnaik780