Conversation
| Kafka func() kafkamgmtclient.DefaultApi | ||
| ServiceAccount func() kafkamgmtclient.SecurityApi | ||
| KafkaAdmin func(kafkaID string) (kafkainstanceclient.DefaultApi, *kafkamgmtclient.KafkaRequest, error) | ||
| KafkaAdmin func(kafkaID string) (kafkainstanceclient.TopicsApi, kafkainstanceclient.GroupsApi, *kafkamgmtclient.KafkaRequest, error) |
Contributor
There was a problem hiding this comment.
Suggested change
| KafkaAdmin func(kafkaID string) (kafkainstanceclient.TopicsApi, kafkainstanceclient.GroupsApi, *kafkamgmtclient.KafkaRequest, error) | |
| KafkaAdmin func(kafkaID string) (kafkainstanceclient, *kafkamgmtclient.KafkaRequest, error) |
If we return the full API client like this, it can be used like: _ = api.TopicsApi.GetTopic()
Collaborator
Author
There was a problem hiding this comment.
Yes. This requires refactor of the KeycloakConnection so it will take some time
Contributor
craicoverflow
left a comment
craicoverflow
left a comment
There was a problem hiding this comment.
I'd like to see us return the full Kafka Admin client as suggested rather than returning multiple API groups
Collaborator
Author
|
@craicoverflow kafkainstanceclient is namespace. |
Collaborator
Author
|
Actually SDK returns: kafkainstanceclient.APIClient and that should be used, however this conflicts with unit testing capabilities etc. Still this is as good we can go without large refactor |
craicoverflow
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New API splits for topics/groups/acls.
I did not add ACL API yet but have concerns how to do update CLI.
We can either do this:
Or this:Opinions? FIrst approach is implemented in PR