Skip to content

fix: cannot delete service registry by name#786

Merged
wtrocki merged 6 commits intomainfrom
registry-delete
Jul 5, 2021
Merged

fix: cannot delete service registry by name#786
wtrocki merged 6 commits intomainfrom
registry-delete

Conversation

@wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Jul 2, 2021

Fixes: #785

@wtrocki wtrocki requested a review from craicoverflow July 2, 2021 08:51
@wtrocki wtrocki force-pushed the registry-delete branch 3 times, most recently from 8ca9262 to 9435e13 Compare July 2, 2021 09:23
@wtrocki
Copy link
Collaborator Author

wtrocki commented Jul 2, 2021

@craicoverflow this fixes broken documentation on master and also minor bug in registry delete.

Copy link
Contributor

@craicoverflow craicoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work when passing the name as a flag:

❯ ./rhoas service-registry delete registry1 -y
Deleting "registry1" Service Registry instance.

Error: 405 Method Not Allowed

You need to change line 117.

@wtrocki
Copy link
Collaborator Author

wtrocki commented Jul 2, 2021

I have tested that before and now. Is there anything special I need to do to replicate this

[wtrocki@graphapi app-services-cli (main ✗)]$ rhoas service-registry create test
Creating Service Registry with name: test
Successfully created Service Registry
{
  "href": "",
  "id": "121",
  "name": "test",
  "owner": "Unauthenticated",
  "registryUrl": "",
  "status": "PROVISIONING"
}
[wtrocki@graphapi app-services-cli (main ✗)]$ rhoas service-registry delete test -y
Deleting "test" Service Registry instance.

Service Registry instance "test" was deleted.

EDIT: Method not allowed was happening before for me when I had outdated SDK.
Can you do go mod tidy and try again for me

@wtrocki wtrocki force-pushed the registry-delete branch from 9435e13 to b26293b Compare July 2, 2021 11:40
@wtrocki
Copy link
Collaborator Author

wtrocki commented Jul 2, 2021

Rebased. Ready for review

@wtrocki wtrocki force-pushed the registry-delete branch from b26293b to 4448308 Compare July 2, 2021 11:42
@rkpattnaik780
Copy link
Contributor

Not able to test it in either mock or staging, is it expected?
Screenshot from 2021-07-02 17-22-53

@rkpattnaik780
Copy link
Contributor

Pasting the debug log:

Screenshot from 2021-07-02 17-34-10

@wtrocki
Copy link
Collaborator Author

wtrocki commented Jul 2, 2021

@rkpattnaik780 sadly enough backend changes broke cli.
Waiting for some fixes..Updated SDK but still some issues in date parsing persist

Change commands to call rhoas service-registry
@wtrocki wtrocki force-pushed the registry-delete branch from 1e572d4 to 5a18b7d Compare July 2, 2021 14:06
@wtrocki wtrocki merged commit 48bad92 into main Jul 5, 2021
@wtrocki wtrocki deleted the registry-delete branch July 5, 2021 12:08
@wtrocki
Copy link
Collaborator Author

wtrocki commented Jul 5, 2021

Backend we have provisioned is broken but running it locally with date fix works. Merged as there are multiple fixed that I needed in follow up PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot delete service registry by name

3 participants