fix: cannot delete service registry by name#786
Merged
Conversation
8ca9262 to
9435e13
Compare
Collaborator
Author
|
@craicoverflow this fixes broken documentation on master and also minor bug in registry delete. |
craicoverflow
suggested changes
Jul 2, 2021
Contributor
craicoverflow
left a comment
There was a problem hiding this comment.
Does not work when passing the name as a flag:
❯ ./rhoas service-registry delete registry1 -y
Deleting "registry1" Service Registry instance.
Error: 405 Method Not AllowedYou need to change line 117.
Collaborator
Author
|
I have tested that before and now. Is there anything special I need to do to replicate this EDIT: Method not allowed was happening before for me when I had outdated SDK. |
Collaborator
Author
|
Rebased. Ready for review |
9 tasks
Contributor
Contributor
Collaborator
Author
|
@rkpattnaik780 sadly enough backend changes broke cli. |
Change commands to call rhoas service-registry
Collaborator
Author
|
Backend we have provisioned is broken but running it locally with date fix works. Merged as there are multiple fixed that I needed in follow up PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes: #785