Skip to content

fix(kafka admin): validations and show proper error messages#729

Merged
craicoverflow merged 2 commits intodevelopfrom
topic_update_check
Jun 21, 2021
Merged

fix(kafka admin): validations and show proper error messages#729
craicoverflow merged 2 commits intodevelopfrom
topic_update_check

Conversation

@rkpattnaik780
Copy link
Contributor

  • Check if topic exists before allowing user to prompt values for update.
  • Show proper status of Kafka instance while performing topic/consumer group operation.

Closes #712 #726

Screenshot from 2021-06-19 01-09-51

Screenshot from 2021-06-19 01-04-39

Verification Steps

  1. Try updating a topic that doesn't exist:
./rhoas kafka topic update <non-existent>
> Error: topic "<non-existent>" does not exist in Kafka instance "test-instance"
  1. Delete a Kafka instance from UI, try listing all the topics in that Kafka instance.
./rhoas kafka topic list
> Error: Kafka instance "<random name>" is being deleted

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@rkpattnaik780 rkpattnaik780 changed the base branch from main to develop June 18, 2021 19:41
@rkpattnaik780 rkpattnaik780 linked an issue Jun 18, 2021 that may be closed by this pull request
@craicoverflow craicoverflow changed the title fix(kafka admin): validations and sow proper error messages fix(kafka admin): validations and show proper error messages Jun 21, 2021
@craicoverflow craicoverflow merged commit ac52cb2 into develop Jun 21, 2021
@craicoverflow craicoverflow deleted the topic_update_check branch June 21, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

topic update should check if topic exists Provide more accurate logs when running Kafka data plane commands

2 participants