feat(kafka topic): add search flag to list subcommand#709
Merged
rkpattnaik780 merged 3 commits intomainfrom Jun 11, 2021
Merged
feat(kafka topic): add search flag to list subcommand#709rkpattnaik780 merged 3 commits intomainfrom
rkpattnaik780 merged 3 commits intomainfrom
Conversation
craicoverflow
suggested changes
Jun 10, 2021
Contributor
craicoverflow
left a comment
craicoverflow
left a comment
There was a problem hiding this comment.
Couple of small changes needed.
|
|
||
| [kafka.topic.list.log.info.noTopics] | ||
| one = 'Kafka instance "{{.InstanceName}}" has no topics. Run "rhoas kafka topic create <topic-name>" to create one' No newline at end of file | ||
| one = 'Kafka instance "{{.InstanceName}}" has no topics. Run "rhoas kafka topic create <topic-name>" to create one' |
Contributor
There was a problem hiding this comment.
Probably this message should not be used when the search flag is use - there could be topics but not showing up because of the filter value.
Contributor
Author
There was a problem hiding this comment.
Indeed! --search for kafka instances returns No kafka instances were found for both no instance created and no instance found after searching. Should we modify the message in same manner for consistency?
Contributor
There was a problem hiding this comment.
No Kafka instance were found is good because it does not call out that there are no topics - just that we did not find any. Sure, let's change the topic message to be consistent :)
craicoverflow
approved these changes
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to filter list of kafka topics by passing
--searchflag torhoas kafka topic listCloses #697
Verification Steps
Error: illegal search value "pic(-1"; only letters (Aa-Zz), numbers, "_", "." and "-" are acceptedgo run ./cmd/rhoas kafka topic list --search <search input>Type of change
Checklist