fix(kafka topic): update regexp for topic name#663
Merged
craicoverflow merged 4 commits intomainfrom May 25, 2021
Merged
Conversation
rkpattnaik780
force-pushed
the
topic_regexp
branch
from
196840e to
a327eb2
Compare
rkpattnaik780
force-pushed
the
topic_regexp
branch
from
a327eb2 to
10c8c76
Compare
rkpattnaik780
changed the title
craicoverflow
approved these changes
May 25, 2021
Contributor
craicoverflow
left a comment
craicoverflow
left a comment
There was a problem hiding this comment.
A couple of small nits which would make small improvements to UX (mainly the error message) but nothing major. Love the tests!
pkg/kafka/topic/validators.go
Outdated
|
|
||
| const ( | ||
| legalNameChars = "^[a-zA-Z0-9\\_\\-]+$" | ||
| legalNameChars = `[a-zA-Z0-9._-]` |
Contributor
There was a problem hiding this comment.
Suggested change
| legalNameChars = `[a-zA-Z0-9._-]` | |
| legalNameChars = "[a-zA-Z0-9._-]" |
pkg/kafka/topic/validators.go
Outdated
| } | ||
|
|
||
| if (name == ".") || (name == "..") { | ||
| return fmt.Errorf(`invalid topic name "%v"; can't be "." or ".."`, name) |
Contributor
There was a problem hiding this comment.
No need to repeat the topic name is we know it is either "." or ".." already.
Suggested change
| return fmt.Errorf(`invalid topic name "%v"; can't be "." or ".."`, name) | |
| return errors.New(`topic name can not be "." or ".."`) |
craicoverflow
approved these changes
May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #654
Verification Steps
kafka.kshould be valid and accepted whereas.and..should be rejected.Type of change
Checklist