Skip to content

fix: Remove token mock#66

Merged
craicoverflow merged 2 commits intomainfrom
mock
Nov 17, 2020
Merged

fix: Remove token mock#66
craicoverflow merged 2 commits intomainfrom
mock

Conversation

@wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Nov 17, 2020

Token mock would not be used in target version thus it makes no sense to use it in the future demoes etc.

@wtrocki
fix: Remove token mock
516e4a7 
Token mock would not be used in target version thus it makes no sense to use it in the future demoes etc.
craicoverflow
craicoverflow suggested changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@craicoverflow craicoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be removed:

https://github.com/bf2fc6cc711aee1a0c2a/cli/blob/506dadc74a67011ca690933e17a3578ead6bacd5/mas-mock/src/index.js#L16

@wtrocki
Copy link
Collaborator Author

wtrocki commented Nov 17, 2020

Done

@craicoverflow craicoverflow self-requested a review November 17, 2020 10:32
@craicoverflow craicoverflow merged commit 17e4d39 into main Nov 17, 2020
@craicoverflow craicoverflow deleted the mock branch November 17, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craicoverflow craicoverflow Awaiting requested review from craicoverflow

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wtrocki @craicoverflow