fix(login): clear MAS tokens from config when using token login#605
Merged
craicoverflow merged 2 commits intoredhat-developer:mainfrom Apr 20, 2021
Merged
Conversation
Collaborator
|
Amazing change! really needed! |
wtrocki
reviewed
Apr 20, 2021
locales/connection/active.en.toml
Outdated
|
|
||
| [connection.error.notLoggedInMASError] | ||
| one = 'not logged in to MAS-SSO. Run "rhoas login" to authenticate' | ||
| one = 'not logged in to MAS-SSO. Run "rhoas login" to authenticate. Note: token-based login is not supported by the Kafka admin commands.' |
Collaborator
There was a problem hiding this comment.
It is not clear what are kafka admin commands. As user I would go and look rhoas kafka admin but we do mix admin commands with control plane ones. It feels that we need to list them to make it more clear.
Something like this: (although you might have better idea how to do it)
Suggested change
| one = 'not logged in to MAS-SSO. Run "rhoas login" to authenticate. Note: token-based login is not supported by the Kafka admin commands.' | |
| one = 'not logged in to MAS-SSO. Run "rhoas login" to authenticate. Note: token-based login is not supported by the Kafka topics and consumergroup commands.' |
wtrocki
approved these changes
Apr 20, 2021
Collaborator
wtrocki
left a comment
There was a problem hiding this comment.
Verified. Minor improvement in message is required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #594
Verification Steps
rhoas login --token=$TOKENrhoas kafka topic list.Type of change
Checklist