fix: return request output format when list is empty#584
Merged
craicoverflow merged 1 commit intoredhat-developer:mainfrom Apr 16, 2021
Merged
Conversation
BREAKING CHANGE: The `list` commands now return the original response object in JSON or YAML, instead of nil, depending on the format requested.
craicoverflow
pushed a commit
that referenced
this pull request
Apr 20, 2021
BREAKING CHANGE: The `list` commands now return the original response object in JSON or YAML, instead of nil, depending on the format requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #579
Verification Steps
Run
rhoas kafka list,rhoas kafka topic list,rhoas serviceaccount listandrhoas kafka consumergroup list, passing-o jsonand-o yml(requires 2 runs).When there are no items, the JSON or YAML will be returned.
$ ./rhoas kafka list -o yaml kind: KafkaRequestList page: 1 size: 0 total: 0 items: [] $ ./rhoas kafka topic list -o json { "count": 0, "items": [], "limit": 0, "offset": 0 }Type of change
Checklist