feat(topic): Show 'Unlimited' when value is -1#559
Merged
craicoverflow merged 2 commits intoredhat-developer:mainfrom Apr 12, 2021
Merged
feat(topic): Show 'Unlimited' when value is -1#559craicoverflow merged 2 commits intoredhat-developer:mainfrom
craicoverflow merged 2 commits intoredhat-developer:mainfrom
Conversation
Contributor
Author
|
@rkpattnaik780 you might want to have something similar in the UI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #488
The -1 value for retention size and retention period means "Unlimited". This adds "Unlimited" to the table alongside the true value of -1.
Verification Steps
Run
rhoas kafka topic list: