Conversation
Contributor
|
The changelog generator will only pick up a Also, one of the following is necessary to highlight that this is breaking change:
https://www.conventionalcommits.org/en/v1.0.0/#specification |
BREAKING CHANGE: This change will mean that old Kafka instances are inaccessible without overriding the MAS-SSO URL
Collaborator
Author
|
The commit is fixed, but I guess as this repo is using squash and merge we need to update the PR too? |
Collaborator
Author
|
I've validated the changes locally now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This change will mean that old Kafka instances are inaccessible without overriding the MAS-SSO URL
Description
Migrates to new Single Sign-on URL.
Hold merging until we get the all clear from @akoserwal
Verification Steps
rhoas loginType of change
Checklist