Skip to content

fix: switch to new mas-sso url#524

Merged
pmuir merged 1 commit intomainfrom
mas-sso-migration
Apr 1, 2021
Merged

fix: switch to new mas-sso url#524
pmuir merged 1 commit intomainfrom
mas-sso-migration

Conversation

@pmuir
Copy link
Collaborator

@pmuir pmuir commented Apr 1, 2021

BREAKING CHANGE: This change will mean that old Kafka instances are inaccessible without overriding the MAS-SSO URL

Description

Migrates to new Single Sign-on URL.

Hold merging until we get the all clear from @akoserwal

Verification Steps

  1. Run rhoas login
  2. Validate that it visits the new URL
  3. Use the Command Line Interface to list the topics on a NEW Kafka instance

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@craicoverflow
Copy link
Contributor

The changelog generator will only pick up a feat, fix and perf type, chores are ignored because a chore usually means a non-code change. Would fix or feat be more suitable?

Also, one of the following is necessary to highlight that this is breaking change:

  • A BREAKING CHANGE: <reason> commit footer
  • Prefix the type with !: fix!: <reason>

https://www.conventionalcommits.org/en/v1.0.0/#specification

BREAKING CHANGE: This change will mean that old Kafka instances are inaccessible without overriding the MAS-SSO URL
@pmuir pmuir force-pushed the mas-sso-migration branch from f346b73 to 02f928c Compare April 1, 2021 08:49
@pmuir
Copy link
Collaborator Author

pmuir commented Apr 1, 2021

The commit is fixed, but I guess as this repo is using squash and merge we need to update the PR too?

@pmuir pmuir removed the do-not-merge label Apr 1, 2021
@pmuir
Copy link
Collaborator Author

pmuir commented Apr 1, 2021

I've validated the changes locally now

@pmuir pmuir changed the title chore: switch to new mas-sso url fix: switch to new mas-sso url Apr 1, 2021
@pmuir pmuir merged commit 53dbbc6 into main Apr 1, 2021
@pmuir pmuir deleted the mas-sso-migration branch April 1, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants