Skip to content

fix(kafka topic): display missing columns from topic list#466

Merged
rkpattnaik780 merged 1 commit intomainfrom
topic_list_cols
Mar 16, 2021
Merged

fix(kafka topic): display missing columns from topic list#466
rkpattnaik780 merged 1 commit intomainfrom
topic_list_cols

Conversation

@rkpattnaik780
Copy link
Contributor

Description

Add missing columns to the topic list table (retention period and retention size).

Screenshot from 2021-03-16 16-38-57

Fixes #459

Verification Steps

  1. Run go run ./cmd/rhoas kafka use <instance name> to select a Kafka instance.
  2. After an instance is selected, run go run ./cmd/rhoas kafka topic list to view the kafka topics in a tabular list.
  3. The Kafka topic list table should have 4 columns - NAME, PARTITIONS, RETENTION TIME and RETENTION SIZE.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@rkpattnaik780 rkpattnaik780 requested a review from wtrocki March 16, 2021 11:15
@rkpattnaik780 rkpattnaik780 merged commit 10618b8 into main Mar 16, 2021
@rkpattnaik780 rkpattnaik780 deleted the topic_list_cols branch March 16, 2021 12:03
@craicoverflow
Copy link
Contributor

Documentation added for the feature

Have the guides also been updated?

@wtrocki
Copy link
Collaborator

wtrocki commented Mar 18, 2021

Is there CLI guide there?

@rkpattnaik780
Copy link
Contributor Author

Will update it in #463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The topic list is missing columns

3 participants