Skip to content

fix: do not throw error when --force is passed#391

Merged
wtrocki merged 1 commit intomainfrom
fix-390
Feb 24, 2021
Merged

fix: do not throw error when --force is passed#391
wtrocki merged 1 commit intomainfrom
fix-390

Conversation

@craicoverflow
Copy link
Contributor

Fixes #390

This was throwing a validation error when the CLI was being running in a non-TTY environment. The fix just required an additional check for the force flag.

Verification

Run rhoas kafka delete with stdin closed and you will get an error to say interactive mode is not available:

true | (setsid ./rhoas kafka delete) 2>&1 | cat
Error: --force required when not running interactively

Run it agin with --force and it will work:

true | (setsid ./rhoas kafka delete -f) 2>&1 | cat
Deleting Kafka instance "ajay-test"

@wtrocki
Copy link
Collaborator

wtrocki commented Feb 24, 2021

Works like dream!

@wtrocki wtrocki merged commit d77df46 into main Feb 24, 2021
@wtrocki wtrocki deleted the fix-390 branch February 24, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: --<no value> required when not running interactively

2 participants