fix(i18n): fix error where locale file not being loaded

[craicoverflow]

fixes #370

This fixes a major bug where locales files which were being loaded in an init function did not load as the file was not found.

The solution to this was to load all message files at the start of the program.

Verification

1. Run make install
2. Run the rhoas CLI from your workspace root ($HOME).

[wtrocki]

@craicoverflow can we measure time before and after load on your mac. How long it takes to load those?

[craicoverflow]

Before:

❯ rhoas whoami
ephelan_kafka_devexp
6.263725ms
❯ rhoas whoami
ephelan_kafka_devexp
5.774509ms
❯ rhoas whoami
ephelan_kafka_devexp
8.273752ms
❯ rhoas whoami
ephelan_kafka_devexp
7.100388ms
❯ rhoas whoami
ephelan_kafka_devexp
12.748368ms
❯ rhoas whoami
ephelan_kafka_devexp
6.429762ms
❯ rhoas whoami
ephelan_kafka_devexp
5.967854ms
❯ rhoas whoami
ephelan_kafka_devexp
8.741398ms
❯ rhoas whoami
ephelan_kafka_devexp
8.619696ms

After:

ephelan_kafka_devexp
6.359273ms
❯ rhoas whoami
ephelan_kafka_devexp
6.031368ms
❯ rhoas whoami
ephelan_kafka_devexp
6.210349ms
❯ rhoas whoami
ephelan_kafka_devexp
7.943102ms
❯ rhoas whoami
ephelan_kafka_devexp
5.666126ms
❯ rhoas whoami
ephelan_kafka_devexp
6.77167ms
❯ rhoas whoami
ephelan_kafka_devexp
8.101047ms

[craicoverflow]

There is no discernible differences.

[craicoverflow]

ping @wtrocki @rkpattnaik780

[wtrocki]

So to clarify. We still compiling codebase using make pkger. but then at runtime we simply load all of the compiled indexes from golang file?

I would go with:

• Create new issue: failing build/release build when make pkger brings any new changes (this will slow build but it is worth it)
• Possibly reduce number of language files over the time. I many time got lost by number of files that were by design loaded in individual code. Since we load them now all it makes sense to organize them to be developer-friendly and aid finding missing/not used keys.

[craicoverflow]

Yep

[wtrocki]

@craicoverflow I would suggest some follow ups for this later phase:

• Create new issue: failing build/release build when make pkger brings any new changes (this will slow build but it is worth it)
• Possibly reduce number of language files over the time. I many time got lost by number of files that were by design loaded in individual code. Since we load them now all it makes sense to organize them to be developer-friendly and aid finding missing/not used keys.