feat(kafka topic): add topic commands

[craicoverflow]

This PR contains changes related to kafka topic subcommands.
This is a work in progress branch that should not get merged until the data plane UI server is live on api.stage.openshift.com.

Running this branch

This branch uses a mocked server hosting in-memory topics. To run the mock server run make mock-api/start. You can see the results API data at http://localhost:8001/topics.

Now you can run rhoas kafka topic list etc.

Tasks

• Add mock server
• Add topic list command
• Add topic create command
• Add topic update command
• Add topic get command
• Add topic delete command
• Add topic deletion confirmation dialogue
• Remove hard-coded call to mock server in KeycloakConnection

Epic Stories

I want create a topic, defining its name and , optionally number of partitions , replication factor and message retention

Run rhoas kafka topic create topic-4 --partitions 2 --replicas 1 --retention-ms -1 to set a custom partition count. The default value is 1.

update the number of partitions configuration of my topic

You can pass --partitions to update the number of partitions. The partition number cannot be decreased.

Example: rhoas kafka topic update topic-4 --replicas 3

I wan to update the topic replication factor

rhoas kafka topic update topic-4 --replicas 3

update the topic message retention

rhoas kafka topic update topic-4 --retention-ms -1

delete an existing topic from my Kafka cluster, including all its messages

rhoas kafka topic delete topic-4

describe a topic and see the detailed configuration of my Kafka topic

rhoas kafka topic topic-4 describe

[wtrocki]

CC @dlabaj - Enda is doing some mocking for the server. It is worth to collaborate on this

[craicoverflow]

@dlabaj in case you were interested - I have written some mock handlers from Strimzi API mock here

https://github.com/bf2fc6cc711aee1a0c2a/cli/blob/topic-commands/mas-mock/src/strimzi-api-handlers.js

[craicoverflow]

Hey @wtrocki this is ready for your review. Please do not merge as it is still relying on the mock API.

[craicoverflow]

Sorry, need to add a confirmation dialogue for deleting a topic.

[craicoverflow]

Ready for review again.

[wtrocki]

How this works? 2 diffrent ports

[craicoverflow]

See https://github.com/bf2fc6cc711aee1a0c2a/cli/blob/topic-commands/pkg/connection/keycloak_connection.go#L175-L177

I decided to hard-code the URL to the API for now as I could not get any of the solutions we discussed to work. This is why this PR should not be merged until the data plane API goes live.

[wtrocki]

Right. Any reason to not combine those API or use different middlewares?

[craicoverflow]

I could not resolve the path issue we were chatting about the other day and it was blocking me from proceeding with the topic commands work.

[wtrocki]

SO this will be resolved when merging or will requires some extra changes in code to test?
Let's sync tomorrow on this (short call)

[craicoverflow]

IMO this PR should not be merged until the API is available on staging because the current topic commands work (somewhat) and are useful to test connecting to the data plane. The new commands only work with a mock environment. Once the API is ready code will be adjusted with original API base url.

If I get time I can try and resolve the URL issue but i have other priorities too and do not want to spend too long on it.

[wtrocki]

Verified with the mock

[craicoverflow]

Updated guides

[craicoverflow]

This is now at 109 files..needs to be merged as keeping it up to date with master is a huge burden. Disabling the topics commands on master.