feat(login page): use Patternfly empty state template#292
Merged
craicoverflow merged 1 commit intomainfrom Jan 26, 2021
Merged
Conversation
craicoverflow
force-pushed
the
login-page
branch
from
e34c8d5 to
8be75db
Compare
wtrocki
reviewed
Jan 26, 2021
| <!DOCTYPE html> | ||
| <head> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com"> | ||
| <link rel="stylesheet" href="https://unpkg.com/@patternfly/patternfly@4.70.2/patternfly.css"> |
Collaborator
There was a problem hiding this comment.
This little thing is going to cost us 5mb ;)
Contributor
Author
There was a problem hiding this comment.
It's 967kb. It is only used on this one page on rare occasions so I do not think this is an issue. Anyway, we need to use Patternfly so there's no alternative.
wtrocki
approved these changes
Jan 26, 2021
craicoverflow
force-pushed
the
login-page
branch
from
8be75db to
6ee509a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #199
This PR uses Patternfly Empty State on the login redirect page.
I used a key icon because we don't have an icon for this community yet.