Merged
Conversation
wtrocki
approved these changes
Jan 15, 2021
Collaborator
|
While this work. I would ask user to retype it's name. |
Contributor
Author
|
That is another good reason to keep this in my opinion. It makes the user be 100% certain they know which instance they are deleting. |
Collaborator
|
But can we tell them which one? Like github - please retype name of the repo. |
Contributor
Author
|
Yes that would work - I was concerned this would still lead to the user copy/pasting it without really thinking about the name |
Contributor
Author
|
Updated with suggestion: ❯ ./rhoas kafka delete
? Are you sure you want to delete the Kafka instance 'enda-test'? Yes
? Confirm the name of the instance you want to permanently delete: enda-test
Kafka instance 'enda-test' has successfully been deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #215
The UI makes the user confirm the name of the Kafka instance when deleting. This PR aligns both interfaces.
It makes more sense to confirm the name as the ID will already have been entered, and is more likely to be pasted from the clipboard, skipping this sanitisation check.