Skip to content

feat(kafka): require name confirmation#227

Merged
wtrocki merged 3 commits intomainfrom
confirm-delete-with-name
Jan 15, 2021
Merged

feat(kafka): require name confirmation#227
wtrocki merged 3 commits intomainfrom
confirm-delete-with-name

Conversation

@craicoverflow
Copy link
Contributor

@craicoverflow craicoverflow commented Jan 14, 2021

Closes #215

The UI makes the user confirm the name of the Kafka instance when deleting. This PR aligns both interfaces.

It makes more sense to confirm the name as the ID will already have been entered, and is more likely to be pasted from the clipboard, skipping this sanitisation check.

❯ ./rhoas kafka delete
? Are you sure you want to delete the Kafka instance 'enda-test'? Yes
? Confirm the name of the instance you want to permanently delete: enda-test
Kafka instance 'enda-test' has successfully been deleted

@craicoverflow craicoverflow requested a review from wtrocki January 15, 2021 09:36
@wtrocki
Copy link
Collaborator

wtrocki commented Jan 15, 2021

While this work. I would ask user to retype it's name.
When I used the command I did not know what kafka I was using so needed to kill command.
Go and check what I'm using and then type it.

@craicoverflow
Copy link
Contributor Author

That is another good reason to keep this in my opinion. It makes the user be 100% certain they know which instance they are deleting.

@wtrocki
Copy link
Collaborator

wtrocki commented Jan 15, 2021

But can we tell them which one? Like github - please retype name of the repo.

@craicoverflow
Copy link
Contributor Author

Yes that would work - I was concerned this would still lead to the user copy/pasting it without really thinking about the name

@craicoverflow
Copy link
Contributor Author

Updated with suggestion:

❯ ./rhoas kafka delete
? Are you sure you want to delete the Kafka instance 'enda-test'? Yes
? Confirm the name of the instance you want to permanently delete: enda-test
Kafka instance 'enda-test' has successfully been deleted

@wtrocki wtrocki merged commit f661229 into main Jan 15, 2021
@wtrocki wtrocki deleted the confirm-delete-with-name branch January 15, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider using the Kafka instance name to confirm deletion

2 participants