feat(connector cluster): add update command#1789
Merged
rkpattnaik780 merged 3 commits intomainfrom Dec 16, 2022
Merged
Conversation
Contributor
jackdelahunt
left a comment
jackdelahunt
left a comment
There was a problem hiding this comment.
Looks good I think we just need more error handling for this
Comment on lines
+96
to
+98
| if apiErr.GetCode() == connectorerror.ERROR_7 { | ||
| return opts.f.Localizer.MustLocalizeError("connector.cluster.update.error.notFound", localize.NewEntry("ID", opts.id)) | ||
| } |
Contributor
There was a problem hiding this comment.
I believe there should be more errors here to catch here
|
functionally lgtm |
Contributor
Author
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add connector cluster update command with flags to change
nameandannotations.Verification Steps
Type of change