feat: generate credentials for Java Kafka client#1783
Merged
rkpattnaik780 merged 1 commit intomainfrom Nov 15, 2022
Merged
Conversation
dimakis
approved these changes
Nov 14, 2022
Contributor
dimakis
left a comment
There was a problem hiding this comment.
LGTM, I verified it, and it did create the credentials.properties correctly. I'm not sure if the content is 💯 accurate as I am not familiar with this part of the code.
| JSONFormat = "json" | ||
| PropertiesFormat = "properties" | ||
| SecretFormat = "secret" | ||
| JavaPropertiesFormat = "java-kafka-properties" |
Contributor
There was a problem hiding this comment.
I would just call it java-properties
Contributor
Author
There was a problem hiding this comment.
That did occur to me. But since .properties file are primarily used for java-related technologies, this name sounded redundant.
There was a problem hiding this comment.
This is java-kafka specific, so the name you've chosen seems reasonable.
Contributor
Author
There was a problem hiding this comment.
Thanks for the verifying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an additional flag to
rhoas service-account createandrhoas service-account reset-credentialsfor supportingpropertiesfile compatible with Java Kafka client.Verification Steps
credentials.propertieswith credentials and callback URL.Type of change