fix(namespace): fix namespace name logging#1773
Merged
jackdelahunt merged 1 commit intoredhat-developer:mainfrom Oct 27, 2022
avano:namespace-create-fix
Merged
fix(namespace): fix namespace name logging#1773jackdelahunt merged 1 commit intoredhat-developer:mainfrom avano:namespace-create-fix
jackdelahunt merged 1 commit intoredhat-developer:mainfrom
avano:namespace-create-fix
Conversation
Contributor
|
Created a namespace with the pr and the issue with localizer is fixed but there is no name being displayed. |
Contributor
Author
|
thanks Jack, that was a different issue - the logged name was always from the |
Contributor
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Fixes an issue with namespace create command:
Also fixes an issue where the name logged is always from the
--namecommand option, not from the actual namespace created