Skip to content

fix(namespace): fix namespace name logging#1773

Merged
jackdelahunt merged 1 commit intoredhat-developer:mainfrom
avano:namespace-create-fix
Oct 27, 2022
Merged

fix(namespace): fix namespace name logging#1773
jackdelahunt merged 1 commit intoredhat-developer:mainfrom
avano:namespace-create-fix

Conversation

@avano
Copy link
Contributor

@avano avano commented Oct 26, 2022

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Fixes an issue with namespace create command:

Successfully created the "<no value>" namespace &{Name my-namespace}

Also fixes an issue where the name logged is always from the --name command option, not from the actual namespace created

@jackdelahunt
Copy link
Contributor

Created a namespace with the pr and the issue with localizer is fixed but there is no name being displayed.

➜  app-services-cli git:(namespace-create-fix) ./rhoas connector namespace create
{
  "annotations": {
    "connector_mgmt.bf2.org/profile": "evaluation-profile"
  },
  "cluster_id": "c9nrsjtcqpu8pmmjl5vg",
  "created_at": "2022-10-27T11:09:40.274733Z",
  "expiration": "2022-10-29T11:09:40.27169Z",
  "href": "/api/connector_mgmt/v1/kafka_connector_namespaces/cdd6dt0oj57achspmeig",
  "id": "cdd6dt0oj57achspmeig",
  "kind": "ConnectorNamespace",
  "modified_at": "2022-10-27T11:09:40.274733Z",
  "name": "inspired-termite-namespace",
  "owner": "jackdelahunt",
  "quota": {
    "connectors": 4,
    "cpu_limits": "2",
    "cpu_requests": "1",
    "memory_limits": "2Gi",
    "memory_requests": "1Gi"
  },
  "resource_version": 863187,
  "status": {
    "connectors_deployed": 0,
    "state": "disconnected"
  },
  "tenant": {
    "id": "jackdelahunt",
    "kind": "user"
  }
}
Successfully created the "" namespace

@avano
Copy link
Contributor Author

avano commented Oct 27, 2022

thanks Jack, that was a different issue - the logged name was always from the --name xyz command option, not from the actual namespace created. hopefully fixed now:

./rhoas connector namespace create
{
  "annotations": {
    "connector_mgmt.bf2.org/profile": "evaluation-profile"
  },
  "cluster_id": "c9nrsjtcqpu8pmmjl5vg",
  "created_at": "2022-10-27T12:07:35.414848Z",
  "expiration": "2022-10-29T12:07:35.412037Z",
  "href": "/api/connector_mgmt/v1/kafka_connector_namespaces/cdd791vb1fq06fd8eq1g",
  "id": "cdd791vb1fq06fd8eq1g",
  "kind": "ConnectorNamespace",
  "modified_at": "2022-10-27T12:07:35.414848Z",
  "name": "regular-boar-namespace",
  "owner": "avano@redhat.com",
  "quota": {
    "connectors": 4,
    "cpu_limits": "2",
    "cpu_requests": "1",
    "memory_limits": "2Gi",
    "memory_requests": "1Gi"
  },
  "resource_version": 863191,
  "status": {
    "connectors_deployed": 0,
    "state": "disconnected"
  },
  "tenant": {
    "id": "avano@redhat.com",
    "kind": "user"
  }
}
Successfully created the "regular-boar-namespace" namespace

@avano avano changed the title fix(namespace): Fix brackets in logger fix(namespace): fix namespace name logging Oct 27, 2022
@jackdelahunt
Copy link
Contributor

LGTM 👍

@jackdelahunt jackdelahunt merged commit 414d281 into redhat-developer:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants