Skip to content

feat: added info on pageination in type list#1723

Merged
jackdelahunt merged 1 commit intomainfrom
info-in-list
Aug 18, 2022
Merged

feat: added info on pageination in type list#1723
jackdelahunt merged 1 commit intomainfrom
info-in-list

Conversation

@jackdelahunt
Copy link
Contributor

Adds some info on the output of connector type list on where the current list is in relation to the pages.

Before

.
.
.
{
    "name": "Apache Cassandra sink",
    "id": "cassandra_sink_0.1",
    "description": "Send data to an Apache Cassandra cluster."
}
{
    "name": "Apache Cassandra source",
    "id": "cassandra_source_0.1",
    "description": "Retrieve data by sending a query to an Apache Cassandra cluster table."
}
{
    "name": "Azure Blob Storage change feed source",
    "id": "azure_storage_blob_changefeed_source_0.1",
    "description": "Receive data from Azure Blob storage change feed."
}
{
    "name": "Azure Blob Storage sink",
    "id": "azure_storage_blob_sink_0.1",
    "description": "Send data to Azure Blob storage."
}
{
    "name": "Azure Blob Storage source",
    "id": "azure_storage_blob_source_0.1",
    "description": "Receive data from Azure Blob storage."
}

After

.
.
.
{
    "name": "Apache Cassandra source",
    "id": "cassandra_source_0.1",
    "description": "Retrieve data by sending a query to an Apache Cassandra cluster table."
}
{
    "name": "Azure Blob Storage change feed source",
    "id": "azure_storage_blob_changefeed_source_0.1",
    "description": "Receive data from Azure Blob storage change feed."
}
{
    "name": "Azure Blob Storage sink",
    "id": "azure_storage_blob_sink_0.1",
    "description": "Send data to Azure Blob storage."
}
{
    "name": "Azure Blob Storage source",
    "id": "azure_storage_blob_source_0.1",
    "description": "Receive data from Azure Blob storage."
}
[page 2 : 10 - 20]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@jackdelahunt jackdelahunt requested a review from wtrocki August 18, 2022 14:23

start := (opts.page - 1) * opts.limit
end := start + len(rows)
opts.f.Logger.Info(fmt.Sprintf("[page %v : %v - %v]", opts.page, start, end))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internationalization ("Page") can be added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@jackdelahunt jackdelahunt merged commit 0619288 into main Aug 18, 2022
@jackdelahunt jackdelahunt deleted the info-in-list branch August 18, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants