Skip to content

feat(service-registry): added --all-groups flag in artifact list command#1667

Merged
wtrocki merged 1 commit intoredhat-developer:mainfrom
SafarMirek:sr-artifacts-list-all-groups
Jul 21, 2022
Merged

feat(service-registry): added --all-groups flag in artifact list command#1667
wtrocki merged 1 commit intoredhat-developer:mainfrom
SafarMirek:sr-artifacts-list-all-groups

Conversation

@SafarMirek
Copy link
Contributor

Closes #1649

Verification Steps

  1. Create two artifacts in two different groups
  2. List all artifacts in all groups and see if there are both of them
    rhoas service-registry artifact list --all-groups

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@wtrocki wtrocki requested a review from jackdelahunt July 21, 2022 11:53
@wtrocki
Copy link
Collaborator

wtrocki commented Jul 21, 2022

Rebase needed.

Copy link
Collaborator

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Really good

@wtrocki wtrocki merged commit 211f739 into redhat-developer:main Jul 21, 2022
@wtrocki
Copy link
Collaborator

wtrocki commented Jul 21, 2022

@jackdelahunt @rkpattnaik780 This would be also included into release. I merged both srs updates and fixes so we can do proper testing before release (some manual testing to see if list and other behave properly after upgrading SDK.

@wtrocki
Copy link
Collaborator

wtrocki commented Jul 21, 2022

@SafarMirek We have integrated new SDK into CLI so you can continue working on second issue.
Amazing work so far. Absolute pleasure to have you contributing to our CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new "--all-groups" flag to "service-registry artifact list"

2 participants