fix: cache connection to skip refreshes#1653
Merged
wtrocki merged 1 commit intoconnectors-v2from Jul 16, 2022
Merged
Conversation
Collaborator
Author
|
Merging without review as this is reverting previous PR etc. We can verify this change by running any command - WE should only see single token refresh happening from now (instead of 7 refreshes before) |
wtrocki
added a commit
that referenced
this pull request
Jul 18, 2022
wtrocki
added a commit
that referenced
this pull request
Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting https://github.com/redhat-developer/app-services-cli/pull/1624/files
This change was to ensure that we mas-sso tokens refresh have been added. Now since mas-sso tokens are gone we should cache our regular sso tokens across session.
This is still not perfect but due to very large amount of connections created in various helpers (kafka create creates -7 connections on it's own - that is 7 sso refreshes per command). Some better refactor for connection objects is needed.
For now we can cache that object as there is no chance that tokens will outdate during single command run (5minutes)