Skip to content

fix: add env var config#1640

Merged
wtrocki merged 8 commits intomainfrom
env-vars
Jul 13, 2022
Merged

fix: add env var config#1640
wtrocki merged 8 commits intomainfrom
env-vars

Conversation

@wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Jul 13, 2022

This fixes problems with offline tokens/refresh tokens when having empty config. I think we should use empty config flag for testing etc.

Verification

RHOASCONFIG="./config.json" rhoas login

RHOASCONFIG="./config.json" rhoas login --token

RHOASCONFIG="./config.json" rhoas login

Notice token login not printing user info but classic login does
Check how config changes when testing

Copy link
Contributor

@rkpattnaik780 rkpattnaik780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wtrocki wtrocki merged commit 6ee3ff0 into main Jul 13, 2022
@wtrocki wtrocki deleted the env-vars branch July 13, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants