Conversation
jackdelahunt
force-pushed
the
connectors-v2
branch
from
e92ba50 to
eefca36
Compare
jackdelahunt
force-pushed
the
connectors-start-stop
branch
2 times, most recently
from
471fa00 to
6db32ad
Compare
pkg/cmd/connector/start/start.go
Outdated
| api := conn.API() | ||
|
|
||
| patch := make(map[string]interface{}) | ||
| patch["desired_state"] = "ready" |
There was a problem hiding this comment.
Replace ready with SDK enum
pkg/cmd/connector/stop/stop.go
Outdated
| api := conn.API() | ||
|
|
||
| patch := make(map[string]interface{}) | ||
| patch["desired_state"] = "stopped" |
There was a problem hiding this comment.
Replace "stopped" with enum from SDK
There was a problem hiding this comment.
I've tried looking for this and just can't find it not saying it doesn't exist just not sure how to effectively to search for it.
There was a problem hiding this comment.
This is big issue for SDKs visibility. If we cannot effectively discover types in editor others would have the same problem with our sdks :(
There is example how to use it etc.
There was a problem hiding this comment.
okay thats fine, the string for each field in the bosy of the request doesn't seem to be anywhere either so might just need to hard code "desired_state"...
wtrocki
left a comment
wtrocki
left a comment
There was a problem hiding this comment.
Some minor docs issues and constants to change. Otherwise looks good
2 participants
This pr adds two new commads for connectors, start and stop. Use to toggle connector instance on and off.
Verification Steps
Create any connector instance and make sure it is working and in the ready state.
rhoas context set-connectorto set that connector to the current connector in the contextrhoas connector stopthen check in the UI if the state of the connector is stoppedrhoas connector startthen check in the UI if the state of the connector is started againrhoas connector start/stop --id=...to toggle the state of any connector without using contextType of change