feat(generate-config): add overwrite flag and change default env file#1604
Merged
rkpattnaik780 merged 1 commit intomainfrom Jun 21, 2022
Merged
feat(generate-config): add overwrite flag and change default env file#1604rkpattnaik780 merged 1 commit intomainfrom
rkpattnaik780 merged 1 commit intomainfrom
Conversation
wtrocki
reviewed
Jun 17, 2022
|
|
||
| [generate.error.configFileAlreadyExists] | ||
| description = 'Error message for when a configuration file alredy exists at a location' | ||
| one = 'file {{.FilePath}} already exists. Use --overwrite to overwrite the file, or the --output-file flag to choose a different location' |
Collaborator
There was a problem hiding this comment.
Suggested change
| one = 'file {{.FilePath}} already exists. Use --overwrite to overwrite the file, or the --output-file flag to choose a different location' | |
| one = 'file {{.FilePath}} already exists. Use --overwrite flag to overwrite the file, or the --output-file flag to choose a different location' |
wtrocki
reviewed
Jun 17, 2022
| one='Type of configuration file to be generated' | ||
|
|
||
| [generate.flag.overwrite.description] | ||
| one = 'Forcibly overwrite a configuration file if it already exists' |
Collaborator
There was a problem hiding this comment.
Suggested change
| one = 'Forcibly overwrite a configuration file if it already exists' | |
| one = 'Overwrite a configuration file if it already exists' |
Collaborator
|
CC @jackdelahunt for verification |
Contributor
|
@rkpattnaik780 Looks good to me 👍 |
jackdelahunt
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default file to save configuration details in environment variables has been changed from
rhoas.envto.envA
--overwriteflag has been added to warn of already existing file.Verification Steps
.envfile:--overwriteflag.Type of change