Skip to content

fix: add tech preview warning#1577

Merged
wtrocki merged 3 commits intomainfrom
add-warning-kafka-size
May 23, 2022
Merged

fix: add tech preview warning#1577
wtrocki merged 3 commits intomainfrom
add-warning-kafka-size

Conversation

@wtrocki
Copy link
Copy Markdown
Collaborator

@wtrocki wtrocki commented May 19, 2022

Adding warning for size x2 of standard instances (subject to change dynamically in near future)
Warning is displayed only when user specifies size (no default sizes are included)

Verification

[wtrocki@graphapi app-services-cli (add-warning-kafka-size ✗)]$ rhoas kafka create --name=test --provider=aws --region us-east-1 --dry-run  --size=x2 
Selected Kafka size is available under technology preview
Dry run successful, arguments are valid
[wtrocki@graphapi app-services-cli (add-warning-kafka-size ✗)]$ rhoas kafka create --name=test --provider=aws --region us-east-1 --dry-run  --size=x1 
Dry run successful, arguments are valid
[wtrocki@graphapi app-services-cli (add-warning-kafka-size ✗)]$ 

[wtrocki@graphapi app-services-cli (add-warning-kafka-size)]$ rhoas kafka create --dry-run
? Name: test
? Cloud Provider: aws
? Cloud Region: us-east-1
? Instance type: x2
Selected Kafka size is available under technology preview
Dry run successful, arguments are valid
[wtrocki@graphapi app-services-cli (add-warning-kafka-size)]$ 

one = 'Instance type:'

[kafka.create.log.info.sizePreview]
one = 'Selected Kafka size is available under technology preview'
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this being good explanation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to point to the official tech preview definition:

This Kafka instance size is a Technology Preview feature. Do not use it for production use. For more information, see https://access.redhat.com/support/offerings/techpreview/.

@wtrocki wtrocki marked this pull request as ready for review May 19, 2022 14:16
@wtrocki wtrocki force-pushed the add-warning-kafka-size branch 2 times, most recently from fd90992 to 2624550 Compare May 19, 2022 14:20
@wtrocki wtrocki force-pushed the add-warning-kafka-size branch from 2624550 to acec9ae Compare May 19, 2022 14:21
Copy link
Copy Markdown
Contributor

@rkpattnaik780 rkpattnaik780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The messages dont fit well when only one size is available:

./rhoas kafka create --dry-run                                                                   
? Name: test-instance-2
? Cloud Provider: aws
? Cloud Region: us-east-1
Selected Kafka size is available under technology preview
Dry run successful, arguments are valid

@wtrocki
Copy link
Copy Markdown
Collaborator Author

wtrocki commented May 23, 2022

The messages dont fit well when only one size is available:

Is that for developer instance? Something might have changed on backend since I have tested that

@rkpattnaik780
Copy link
Copy Markdown
Contributor

The messages dont fit well when only one size is available:

Is that for developer instance? Something might have changed on backend since I have tested that

Yes, it was developer instance.

@wtrocki
Copy link
Copy Markdown
Collaborator Author

wtrocki commented May 23, 2022

{
   "instance_types":[
      {
         "id":"developer",
         "display_name":"Trial",
         "sizes":[
            {
               "id":"x1",
               "display_name":"1",
               "quota_consumed":1,
               "quota_type":"RHOSAKTrial",
               "capacity_consumed":1,
               "maturity_status":"preview"
            }
         ]
      
         ]
      }
   ]
}

Looks like developer instances have maturity status as "preview" which doesn't seem right. We should only have x2 standard . @pb82 WDYT?

@pb82
Copy link
Copy Markdown

pb82 commented May 23, 2022

@wtrocki wtrocki requested a review from rkpattnaik780 May 23, 2022 11:31
@wtrocki
Copy link
Copy Markdown
Collaborator Author

wtrocki commented May 23, 2022

@rkpattnaik780 Tech preview from developer should be removed in 30 minutes timeframe.

@wtrocki
Copy link
Copy Markdown
Collaborator Author

wtrocki commented May 23, 2022

Developer is now listed as stable.

@wtrocki wtrocki merged commit f9fb934 into main May 23, 2022
@wtrocki wtrocki deleted the add-warning-kafka-size branch May 23, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants