Conversation
wtrocki
commented
Mar 11, 2022
| return err | ||
| } | ||
|
|
||
| offsetEnum, _ := kafkainstanceclient.NewOffsetTypeFromValue(opts.offset) |
Collaborator
Author
There was a problem hiding this comment.
Not sure if we should handle error as we are doing validation before so we are guaranteed to have valid offset.
Contributor
There was a problem hiding this comment.
We can skip handling here.
wtrocki
commented
Mar 11, 2022
| apiURL, _ = url.Parse(apiHost) | ||
| apiURL.Scheme = "https" | ||
| apiURL.Path = "/rest" | ||
| apiURL.Path = "/" |
Collaborator
Author
There was a problem hiding this comment.
This should have zero impact when we move to /api/v1
rkpattnaik780
approved these changes
Mar 14, 2022
| return err | ||
| } | ||
|
|
||
| offsetEnum, _ := kafkainstanceclient.NewOffsetTypeFromValue(opts.offset) |
Contributor
There was a problem hiding this comment.
We can skip handling here.
Collaborator
Author
|
@rkpattnaik780 I will merge so we can do automatic tests and rebase other PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have verified all commands manually:
Just minor changes were required.