Skip to content

fix: build failing at test#1469

Merged
rkpattnaik780 merged 1 commit intomainfrom
fix_build
Mar 10, 2022
Merged

fix: build failing at test#1469
rkpattnaik780 merged 1 commit intomainfrom
fix_build

Conversation

@rkpattnaik780
Copy link
Contributor

The build is currently failing as flag description for topic retention byte ends with a fullstop.

Verification Steps

The build GitHub action should pass.

--- FAIL: Test_ValidateCommandsUsingCharmilValidator (0.01s)
    validator_test.go:56: validationErr was not empty, got length: 2; want 0
    validator_test.go:61: PUNCTUATION_RULE: cmd rhoas kafka topic create: full stop in the flag usage
    validator_test.go:61: PUNCTUATION_RULE: cmd rhoas kafka topic update: full stop in the flag usage

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@rkpattnaik780 rkpattnaik780 merged commit bc1ea0e into main Mar 10, 2022
@rkpattnaik780 rkpattnaik780 deleted the fix_build branch March 10, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant