feat: auto-use kafka cluster after creation#142
Merged
Conversation
Contributor
Author
|
This is still a WIP, discussion around implementation considerations is ongoing in #135 |
59c6a43 to
3825190
Compare
3825190 to
9f6b1fc
Compare
This was
linked to
issues
Dec 9, 2020
Collaborator
|
Verified. This will conflict with stuff I have so let's merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an improvement suggested in #50
The issue with this is that the bootstrap server host is not available at this stage and so ClusterHost will be empty in the config.
Now when you create a Kafka cluster it is automatically used.
To achieve this, now only the Kafka Cluster ID id stored in the config, the Host and Name are fetched in real-time from the API, providing validation and ensuring the fields are up-to-date. See
3825190(#142)Also related: #135