SDK errors

[wtrocki]

Verification

rhoas service-registry create # reach limits 
rhoas service registry describe --name=whatever
rhoas service registry describe --id=whatever

Notes (outdated)

Current problems I see:

1. Lack way to handle errors per SDK (API exposing hasError etc.) so we need to define errors in multiple places/defefine them or have helper methods for creating proper message per type.

2. Errors type should be probably moved to the core and not defined for kafka specifically

3. SDK on its own defines all errors on root package. Maybe we should have kafkaerrors.ERROR_40 instead?

[craicoverflow]

Current problems I see:
SDK on its own defines all errors on root package. Maybe we should have kafkaerrors.ERROR_40 instead?

I just have a question - can you explain further what the problem you see is?

[wtrocki]

There are 80 fields in the root of the SDK (from which 95% are errors constants)

[craicoverflow]

Thanks that is clear!

[wtrocki]

It wasn't possible to add localization to those (same as kafka) due to them being used in different context that do not have localiser injected. I think it is good to have those 2 localized and will add that after this PR (it will require a looot of changes that will obfuscate this PR)

[craicoverflow]

You could create a ServiceRegistryErrors struct to wrap these errors?

[craicoverflow]

LGTM

[craicoverflow]

You could return the error inline?

[wtrocki]

Oh.. yes. That was copy paste from kafka errors.

[craicoverflow]

You could create a ServiceRegistryErrors struct to wrap these errors?

[wtrocki]

It feels like this was overkill to handle only 3 errors from srs (as all kafka errors were handled already).
We should try to refactor error handling in the CLI but I see this as step process where we improve new and existing commands rather than doing this as whole.