feat: refactor connect to use top level group#139
Merged
Conversation
wtrocki
force-pushed
the
connect-refactor
branch
2 times, most recently
from
56a58b1 to
7782a81
Compare
Contributor
|
Needs rebase |
| } | ||
|
|
||
| cmd.Flags().BoolVarP(&secretOnly, "secret-only", "", false, "Apply only secret and without CR. Can be used without installing RHOAS operator on cluster") | ||
| cmd.Flags().BoolVarP(&forceSelect, "skip-context", "", false, "Allows to select services before performing binding") |
Contributor
There was a problem hiding this comment.
How will this work in the future when we have more services? How will it know what to choose?
Collaborator
Author
There was a problem hiding this comment.
Yes.. I wanted to keep things really generic so we already have abstraction of services in config and ability to select one..
There is also environment abstraction that we need to do etc.
Collaborator
Author
|
Just noticed. Sorry. DOing it |
wtrocki
force-pushed
the
connect-refactor
branch
from
c83a007 to
4f7deec
Compare
craicoverflow
approved these changes
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verification