fix: add plural form for ACL messages#1369
Merged
craicoverflow merged 1 commit intomainfrom Jan 6, 2022
Merged
Conversation
wtrocki
reviewed
Jan 6, 2022
| [kafka.acl.grantPermissions.log.info.aclsPreview] | ||
| one = 'The following ACL rule is going to be created:' | ||
| one = 'The following ACL rule will be created:' | ||
| other = 'The following ACL rules will be created:' |
wtrocki
approved these changes
Jan 6, 2022
Collaborator
|
Verified. Good to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The i18n library allows you to pass a number to indicate plurality, so I updated the messages to have a plural and singular form.
Closes #1300
Verification Steps
Plural grant-access
Singular grant-admin
$ rhoas kafka acl grant-admin --all-accounts The following ACL rule will be created: PRINCIPAL PERMISSION OPERATION DESCRIPTION -------------- ------------ ----------- ---------------------------- All Accounts allow alter cluster is "kafka-cluster"Singular delete
Type of change
Checklist