fix: use mapped lowercase values in ACL table#1292
Merged
craicoverflow merged 2 commits intoredhat-developer:mainfrom Nov 5, 2021
Merged
fix: use mapped lowercase values in ACL table#1292craicoverflow merged 2 commits intoredhat-developer:mainfrom
craicoverflow merged 2 commits intoredhat-developer:mainfrom
Conversation
Contributor
Author
|
Guides updated: #1247 |
wtrocki
reviewed
Nov 5, 2021
pkg/kafka/aclutil/acl_table.go
Outdated
|
|
||
| // get the SDK => CLI key mappings | ||
| operationMap := GetOperationMap() | ||
| flippedOperationMap := make(map[kafkainstanceclient.AclOperation]string) |
Collaborator
There was a problem hiding this comment.
What flipped means? I see we deep copy map
Contributor
Author
There was a problem hiding this comment.
Reversed, will change.
Collaborator
|
Opinionated take: |
wtrocki
approved these changes
Nov 5, 2021
9f0fe7f to
6d0bf71
Compare
6d0bf71 to
2ea178c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1247
Verification Steps
Run
rhoas kafka acl list:Type of change
Checklist