Conversation
Collaborator
Author
|
Once this PR is deployed to production: redhat-developer/app-services-ui#153 we should change URL from github to the console.redhat.com |
wtrocki
commented
Nov 4, 2021
wtrocki
commented
Nov 4, 2021
wtrocki
commented
Nov 4, 2021
wtrocki
force-pushed
the
registry-broken
branch
from
d1b7007 to
73a4604
Compare
Collaborator
Author
|
@craicoverflow added verification steps in .cases/termsandconditions.sh |
Collaborator
Author
|
Investigating unrelated issues with missing debug level logging |
craicoverflow
approved these changes
Nov 4, 2021
Contributor
craicoverflow
left a comment
craicoverflow
left a comment
There was a problem hiding this comment.
One comment about checking for nil response, other than that all good.
| @@ -0,0 +1,20 @@ | |||
| #!/bin/bash | |||
Contributor
There was a problem hiding this comment.
Getting permission denied on this file. Should it be automatically executable? On my Linux machine it was, could be different on MacOS though..
Collaborator
Author
There was a problem hiding this comment.
Amazing feedback. I will move those to md files as sh doesnt make sense when we copy commands to execute
We can have template for new verification
Co-authored-by: Enda <ephelan@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires extra work and untested but code should be ok to review.
Fixes #1275