Skip to content

feat: add wildcard alias for ACL resource name#1255

Merged
craicoverflow merged 1 commit intoredhat-developer:mainfrom
craicoverflow:revert-wildcard-removal
Oct 26, 2021
Merged

feat: add wildcard alias for ACL resource name#1255
craicoverflow merged 1 commit intoredhat-developer:mainfrom
craicoverflow:revert-wildcard-removal

Conversation

@craicoverflow
Copy link
Contributor

@craicoverflow craicoverflow commented Oct 26, 2021

This pull request adds "all" as a valid alias for specifying all resources, which is usually an asterisk (*).

Verification

Run the delete command, passing "all" for any resource type (topic, group, transactional-id). This will be mapped to *.

$ rhoas kafka acl delete --topic all --operation describe-configs --permission allow --all-accounts 
⚠ The following ACLs will be deleted from Kafka instance "enda-dev":

  PRINCIPAL      PERMISSION   OPERATION          DESCRIPTION   
 -------------- ------------ ------------------ -------------- 
  All accounts   ALLOW        DESCRIBE_CONFIGS   TOPIC is "*" 

@craicoverflow craicoverflow force-pushed the revert-wildcard-removal branch from 7e30931 to fce8a98 Compare October 26, 2021 13:47
@craicoverflow craicoverflow marked this pull request as ready for review October 26, 2021 13:47
@craicoverflow craicoverflow changed the title revert wildcard removal feat: add wildcard alias for ACL resource name Oct 26, 2021
@craicoverflow craicoverflow merged commit 37993a7 into redhat-developer:main Oct 26, 2021
@craicoverflow craicoverflow deleted the revert-wildcard-removal branch October 26, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants