fix: add token endpoint URL to credentials file#1177
Merged
craicoverflow merged 1 commit intomainfrom Oct 4, 2021
Merged
Conversation
craicoverflow
force-pushed
the
fix-add-token-url
branch
from
a4791d2 to
e6df3f7
Compare
Contributor
Author
|
Quick bug fix. |
Collaborator
|
That was fast :) Was reviewing it :D |
wtrocki
reviewed
Oct 4, 2021
| creds := &credentials.Credentials{ | ||
| ClientID: updatedServiceAccount.GetClientId(), | ||
| ClientSecret: updatedServiceAccount.GetClientSecret(), | ||
| TokenURL: cfg.MasAuthURL + "/protocol/openid-connect/token", |
Collaborator
There was a problem hiding this comment.
Suggested change
| TokenURL: cfg.MasAuthURL + "/protocol/openid-connect/token", | |
| TokenURL: cfg.MasAuthURL + serviceaccount.TOKEN_URL_SUFFIX, |
Contributor
Author
There was a problem hiding this comment.
Yeah, realistically we should not be concatenating the URL like this, rather use something like ResolveReference (or something else), in case there are extra characters.
app-services-cli/pkg/api/rbac/api.go
Line 130 in db1abd9
Just wanted a quick fix so I copy/pasted it for now :)
Collaborator
|
nice catch! I totally forgot about reset. |
craicoverflow
pushed a commit
to craicoverflow/app-services-cli
that referenced
this pull request
Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Verification Steps
Type of change
Checklist