Skip to content

fix: remove double-login messages#1031

Merged
craicoverflow merged 1 commit intomainfrom
login-debug-message
Sep 6, 2021
Merged

fix: remove double-login messages#1031
craicoverflow merged 1 commit intomainfrom
login-debug-message

Conversation

@craicoverflow
Copy link
Contributor

Verification Steps

Log in, and you will not see the messages related to MAS-SSO unless you pass the -v flag.

$ rhoas login
Logging in...
Logged in successfully

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

@rkpattnaik780
Copy link
Contributor

rkpattnaik780 commented Sep 6, 2021

Passing -v flag doesnt print the debug logs. Noticed this now!
Screenshot from 2021-09-06 17-14-06

@craicoverflow
Copy link
Contributor Author

Interesting..that seems to be a pre-existing bug 🤔 I'll create a separate issue for it.

@craicoverflow craicoverflow merged commit 2b32b75 into main Sep 6, 2021
@craicoverflow craicoverflow deleted the login-debug-message branch September 6, 2021 12:56
rkpattnaik780 pushed a commit that referenced this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants