fix: check if http.Response is nil before closing body#1011
Merged
craicoverflow merged 2 commits intomainfrom Sep 2, 2021
Merged
fix: check if http.Response is nil before closing body#1011craicoverflow merged 2 commits intomainfrom
craicoverflow merged 2 commits intomainfrom
Conversation
craicoverflow
force-pushed
the
check-if-body-exists
branch
from
000786d to
24c5d0d
Compare
wtrocki
approved these changes
Sep 1, 2021
craicoverflow
force-pushed
the
check-if-body-exists
branch
from
24c5d0d to
0b404f1
Compare
rkpattnaik780
pushed a commit
that referenced
this pull request
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up to the bug uncovered by @alexal in #1009 to ensure all
http.Responseare checked for nil before the body is closed.Verification Steps
Run through the commands to create kafka, service-account etc.
Type of change
Checklist