Skip to content

Telemetry implementation#1005

Merged
wtrocki merged 6 commits intomainfrom
telemetry
Nov 1, 2021
Merged

Telemetry implementation#1005
wtrocki merged 6 commits intomainfrom
telemetry

Conversation

@wtrocki
Copy link
Collaborator

@wtrocki wtrocki commented Aug 31, 2021

Telemetry commands

Screenshot 2021-09-01 at 17 11 36

Challenges

Asking users to comply with analytics on first usage

https://developers.redhat.com/article/tool-data-collection

Preventing counting internal usage

  • Prevening help/completion commands to send data
  • Preventing non TTY sessions
  • Adding env var along with config for internal team do disable telemetry.

Preventing sending usage for meta commands

__completion, help etc. should not send analytics

@wtrocki
Copy link
Collaborator Author

wtrocki commented Aug 31, 2021

rhoas telemetry test

Screenshot 2021-08-31 at 17 35 33

@wtrocki
Copy link
Collaborator Author

wtrocki commented Oct 28, 2021

I'm interested in your feedback about how we sent telemetry, enable telemetry itself and also segment integration.
You should have access to dev segment account etc.
Screenshot 2021-10-28 at 17 22 33

Copy link
Contributor

@craicoverflow craicoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed a bit and verified from CLI side. Tomorrow I will look at the analytics dashboard.

Question: what if the user changes their mind and wants to later opt-out? Should be be providing an easy way to opt-out again?

@wtrocki
Copy link
Collaborator Author

wtrocki commented Oct 28, 2021

Question: what if the user changes their mind and wants to later opt-out? Should be be providing an easy way to opt-out again?

ODO and other commands have config comand that allow to change config. I think if you want to turn it off you should set env variable

@craicoverflow
Copy link
Contributor

I think if you want to turn it off you should set env variable

Do users know about this environment variable to do so if they wish?

@wtrocki
Copy link
Collaborator Author

wtrocki commented Oct 29, 2021

USAGE_DATA.md contains some info about it. Can we put it in other places?

@craicoverflow
Copy link
Contributor

USAGE_DATA.md contains some info about it. Can we put it in other places?

How many customers will look at this repo to finds that out? Should it be included as part of the confirmation message when opting in?

@wtrocki
Copy link
Collaborator Author

wtrocki commented Oct 29, 2021

Should it be included as part of the confirmation message when opting in?

Would do

Copy link
Contributor

@craicoverflow craicoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors don't seem to be logged (comment left inline)

@wtrocki
Copy link
Collaborator Author

wtrocki commented Oct 29, 2021

To verify you would need to build production version (non dev) or.. use environment variable.
I'm working on connecting this with production.

I think initially we can release this feature enabled only in dev mode and after legal enables us to collect details we can switch to all users.

@wtrocki
Copy link
Collaborator Author

wtrocki commented Nov 1, 2021

Errors are sent
Screenshot 2021-11-01 at 16 39 31

@wtrocki wtrocki merged commit c97509d into main Nov 1, 2021
@wtrocki wtrocki deleted the telemetry branch November 1, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants