Skip to content

Commit f4c503e

Browse files
committed
apply review suggestions
1 parent 12cce2e commit f4c503e

File tree

6 files changed

+13
-5
lines changed

6 files changed

+13
-5
lines changed

cmd/rhoas/pkged.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/commands/rhoas_kafka_consumergroup_describe.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ rhoas kafka consumergroup describe [flags]
1717

1818
....
1919
# describe a consumer group
20-
$ rhoas kafka consumergroup describe --id consumer_group_1 -o json
20+
$ rhoas kafka consumergroup describe consumer_group_1 -o json
2121
2222
....
2323

locales/cmd/kafka/consumergroup/common/active.en.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ other = 'you are forbidden to {{.Operation}} these consumer groups'
1515
one = 'internal server error'
1616

1717
[kafka.consumerGroup.common.error.notFoundError]
18-
one = 'topic "{{.TopicName}}" not found in Kafka instance "{{.InstanceName}}"'
18+
one = 'consumer group "{{.ConsumerGroupID}}" not found in Kafka instance "{{.InstanceName}}"'
1919

2020
[kafka.consumerGroup.common.error.unableToConnectToKafka]
2121
one = 'unable to connect to Kafka instance "{{.Name}}"'

locales/cmd/kafka/consumergroup/describe/active.en.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Print detailed information for a consumer group and its members.
1212
[kafka.consumerGroup.describe.cmd.example]
1313
one = '''
1414
# describe a consumer group
15-
$ rhoas kafka consumergroup describe --id consumer_group_1 -o json
15+
$ rhoas kafka consumergroup describe consumer_group_1 -o json
1616
'''
1717

1818
[kafka.consumerGroup.describe.output.id]

locales/cmd/login/active.en.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ one = 'You are now logged in to MAS-SSO as <span style="font-weight:700">{{.User
7373

7474
[login.error.schemeMissingFromUrl]
7575
description = 'Error message for when scheme is missing from the Auth URL'
76-
one = 'scheme missing from URL "{{.URL}}". Please add either "https" or "https"'
76+
one = 'scheme missing from URL "{{.URL}}". Please add either "http" or "https"'
7777

7878
[login.log.debug.createdAuthorizationUrl]
7979
description = 'Debug message to show the authorization URL'

pkg/cmd/kafka/consumergroup/describe/describe.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,14 @@ func runCmd(opts *Options) error {
121121
"Operation": "view",
122122
},
123123
}))
124+
case 404:
125+
return errors.New(localizer.MustLocalize(&localizer.Config{
126+
MessageID: "kafka.consumerGroup.common.error.notFoundError",
127+
TemplateData: map[string]interface{}{
128+
"ConsumerGroupID": opts.id,
129+
"InstanceName": kafkaInstance.GetName(),
130+
},
131+
}))
124132
case 500:
125133
return fmt.Errorf("%v: %w", localizer.MustLocalizeFromID("kafka.consumerGroup.common.error.internalServerError"), consumerGroupErr)
126134
case 503:

0 commit comments

Comments
 (0)