Skip to content

Commit 9ce7da4

Browse files
author
Enda Phelan
committed
chore: show descriptive error message
1 parent 1e237e8 commit 9ce7da4

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

cmd/rhoas/pkged.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

locales/cmd/kafka/consumergroup/delete/active.en.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,7 @@ description = 'Info message when user chose not to delete consumer group'
2727
one = 'Consumer group delete action was not confirmed. Exiting silently'
2828

2929
[kafka.consumerGroup.delete.log.info.consumerGroupDeleted]
30-
one = 'Consumer group with ID "{{.ConsumerGroupID}}" has been deleted from the Kafka instance "{{.InstanceName}}"'
30+
one = 'Consumer group with ID "{{.ConsumerGroupID}}" has been deleted from the Kafka instance "{{.InstanceName}}"'
31+
32+
[kafka.consumerGroup.delete.error.locked]
33+
one = 'not allowed to delete a consumer group with active members'

pkg/cmd/kafka/consumergroup/consumergroup.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import (
55
"github.com/redhat-developer/app-services-cli/pkg/cmd/factory"
66
"github.com/redhat-developer/app-services-cli/pkg/cmd/kafka/consumergroup/delete"
77
"github.com/redhat-developer/app-services-cli/pkg/cmd/kafka/consumergroup/describe"
8-
"github.com/redhat-developer/app-services-cli/pkg/cmd/kafka/consumergroup/list"
98
"github.com/spf13/cobra"
109
)
1110

@@ -20,7 +19,7 @@ func NewConsumerGroupCommand(f *factory.Factory) *cobra.Command {
2019
}
2120

2221
cmd.AddCommand(
23-
list.NewListConsumerGroupCommand(f),
22+
// list.NewListConsumerGroupCommand(f),
2423
delete.NewDeleteConsumerGroupCommand(f),
2524
describe.NewDescribeConsumerGroupCommand(f),
2625
)

pkg/cmd/kafka/consumergroup/delete/delete.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,8 @@ func runCmd(opts *Options) error {
150150
"Operation": "delete",
151151
},
152152
}))
153+
case 423:
154+
return errors.New(localizer.MustLocalizeFromID("kafka.consumerGroup.delete.error.locked"))
153155
case 500:
154156
return errors.New(localizer.MustLocalizeFromID("kafka.consumerGroup.common.error.internalServerError"))
155157
case 503:

0 commit comments

Comments
 (0)