Skip to content

Commit 8edfc44

Browse files
author
Enda
authored
feat(kafka acl): add acl delete command (#1218)
1 parent 4c3adf2 commit 8edfc44

File tree

31 files changed

+1491
-355
lines changed

31 files changed

+1491
-355
lines changed

.golangci.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ run:
1212
# from this option's value (see skip-dirs-use-default).
1313
# "/" will be replaced by current OS file path separator to properly work
1414
# on Windows.
15+
skip-files:
16+
- '.*_test.go'
1517
#skip-dirs:
1618
# - .chglog
1719
# output configuration options

cmd/rhoas/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func initConfig(f *factory.Factory) error {
9191
func rootError(err error, localizer localize.Localizer) error {
9292
prefix := icon.ErrorPrefix()
9393
errMessage := err.Error()
94-
if prefix == icon.CrossMark {
94+
if prefix == icon.ErrorSymbol {
9595
errMessage = firstCharToUpper(errMessage)
9696
}
9797
return fmt.Errorf("%v %v. %v", icon.ErrorPrefix(), errMessage, localizer.MustLocalize("common.log.error.verboseModeHint"))

docs/commands/rhoas_kafka_acl.adoc

Lines changed: 17 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/commands/rhoas_kafka_acl_delete.adoc

Lines changed: 66 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/commands/rhoas_kafka_acl_grant-access.adoc

Lines changed: 21 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/commands/rhoas_kafka_acl_list.adoc

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/cmd/kafka/acl/acl.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package acl
22

33
import (
44
"github.com/redhat-developer/app-services-cli/pkg/cmd/factory"
5+
"github.com/redhat-developer/app-services-cli/pkg/cmd/kafka/acl/delete"
56
"github.com/redhat-developer/app-services-cli/pkg/cmd/kafka/acl/grant"
67
"github.com/redhat-developer/app-services-cli/pkg/cmd/kafka/acl/list"
78
"github.com/spf13/cobra"
@@ -20,6 +21,7 @@ func NewAclCommand(f *factory.Factory) *cobra.Command {
2021
cmd.AddCommand(
2122
list.NewListACLCommand(f),
2223
grant.NewGrantPermissionsACLCommand(f),
24+
delete.NewDeleteCommand(f),
2325
)
2426

2527
return cmd

0 commit comments

Comments
 (0)