fix(iostreams): make coloured output work on Windows (#625)

Author: Enda

mas-mock/_data_/consumer-groups.json

@@ -1,6 +1,6 @@
 [
   {
-    "id": "consumer_group_1",
+    "groupId": "consumer_group_1",
     "consumers": [
       {
         "groupId": "consumer_group_1",
@@ -23,7 +23,7 @@
     ]
   },
   {
-    "id": "consumer_group_2",
+    "groupId": "consumer_group_2",
     "consumers": [
       {
         "groupId": "consumer_group_2",

mas-mock/src/handlers/kafka-admin.js

@@ -139,7 +139,7 @@ module.exports = {
 };
 
 function getConsumerGroup(id) {
-  return consumerGroups.find(c => c.id === id);
+  return consumerGroups.find(c => c.groupId === id);
 }
 
 function getTopic(name) {

pkg/cmd/kafka/consumergroup/describe/describe.go

@@ -197,6 +197,7 @@ func mapConsumerGroupDescribeToTableFormat(consumers []strimziadminclient.Consum
 	return rows
 }
 
+// print the consumer grooup details
 func printConsumerGroupDetails(w io.Writer, consumerGroupData strimziadminclient.ConsumerGroup) {
 	fmt.Fprintln(w, "")
 	consumers := consumerGroupData.GetConsumers()

pkg/color/color.go

@@ -3,6 +3,7 @@ package color
 
 import (
 	"fmt"
+	"runtime"
 
 	"github.com/fatih/color"
 )
@@ -27,6 +28,12 @@ func Error(format string) string {
 	return color.HiRedString(format)
 }
 
+// Bold makes a string bold
 func Bold(s string) string {
+	// do not bold the string if the current OS is Windows
+	// Command Prompt does not support ANSI escape characters
+	if runtime.GOOS == "windows" {
+		return s
+	}
 	return fmt.Sprintf("\033[1m%v\033[0m", s)
 }

pkg/iostreams/iostreams.go

@@ -4,6 +4,7 @@ import (
 	"io"
 	"os"
 
+	"github.com/fatih/color"
 	"github.com/mattn/go-isatty"
 )
 
@@ -92,8 +93,8 @@ func System() *IOStreams {
 	io := &IOStreams{
 		In:          os.Stdin,
 		originalOut: os.Stdout,
-		Out:         os.Stdout,
-		ErrOut:      os.Stderr,
+		Out:         color.Output,
+		ErrOut:      color.Error,
 	}
 
 	// prevent duplicate isTerminal queries now that we know the answer