fix(serviceaccount): allow capital letters in description (#550)

Author: Enda

cmd/rhoas/pkged.go

@@ -81,7 +81,7 @@ one = 'service account name cannot exceed {{.MaxNameLen}} characters'
 one = 'invalid service account name "{{.Name}}"; only lowercase letters (a-z), numbers, and "-" are accepted'
 
 [serviceAccount.common.validation.description.error.invalidChars]
-one = 'invalid service account description "{{.Description}}"; only lowercase letters (a-z) and numbers are accepted'
+one = 'invalid service account description "{{.Description}}"; only alphanumeric characters are accepted'
 
 [serviceAccount.common.validation.description.error.lengthError]
 one = 'service account description cannot exceed {{.MaxNameLen}} characters'

locales/cmd/serviceaccount/active.en.toml

@@ -13,7 +13,7 @@ const (
 	maxNameLength  = 50
 	minNameLength  = 1
 	// description validation rules
-	legalDescriptionChars = "^[a-z0-9\\s]*$"
+	legalDescriptionChars = "^[a-zA-Z0-9\\s]*$"
 	maxDescriptionLength  = 255
 )
 

pkg/serviceaccount/validation/validation.go

@@ -110,9 +110,9 @@ func TestValidateDescription(t *testing.T) {
 			wantErr: true,
 		},
 		{
-			name:    "fails with capital letters",
+			name:    "passes with capital letters",
 			args:    args{"Hello"},
-			wantErr: true,
+			wantErr: false,
 		},
 	}
 	for _, tt := range tests {