fix: misformatted error message (#669)

Author: Enda

pkg/cmd/kafka/consumergroup/list/list.go

@@ -180,10 +180,10 @@ func checkForConsumerGroups(count int, opts *Options, kafkaName string) (hasCoun
 	if err != nil {
 		return false, err
 	}
-	kafkaNameTmplPair := localize.NewEntry("Name", kafkaName)
+	kafkaNameTmplPair := localize.NewEntry("InstanceName", kafkaName)
 	if count == 0 && opts.output == "" {
 		if opts.topic == "" {
-			logger.Info(opts.localizer.MustLocalize("kafka.consumerGroup.list.log.info.noConsumerGroups"), kafkaNameTmplPair)
+			logger.Info(opts.localizer.MustLocalize("kafka.consumerGroup.list.log.info.noConsumerGroups", kafkaNameTmplPair))
 		} else {
 			logger.Info(opts.localizer.MustLocalize("kafka.consumerGroup.list.log.info.noConsumerGroupsForTopic"), kafkaNameTmplPair, localize.NewEntry("TopicName", opts.topic))
 		}

pkg/cmd/kafka/topic/list/list.go

@@ -111,9 +111,9 @@ func runCmd(opts *Options) error {
 		operationTemplatePair := localize.NewEntry("Operation", "list")
 		switch httpRes.StatusCode {
 		case 401:
-			return errors.New(opts.localizer.MustLocalize("kafka.topic.list.common.error.unauthorized", operationTemplatePair))
+			return errors.New(opts.localizer.MustLocalize("kafka.topic.list.error.unauthorized", operationTemplatePair))
 		case 403:
-			return errors.New(opts.localizer.MustLocalize("kafka.topic.list.common.error.forbidden", operationTemplatePair))
+			return errors.New(opts.localizer.MustLocalize("kafka.topic.list.error.forbidden", operationTemplatePair))
 		case 500:
 			return errors.New(opts.localizer.MustLocalize("kafka.topic.common.error.internalServerError"))
 		case 503:

pkg/httputil/logging_round_tripper.go

@@ -15,12 +15,18 @@ type LoggingRoundTripper struct {
 }
 
 // RoundTrip logs the http request and response in debug mode
+// for all errors, where status code >= 400
 func (c LoggingRoundTripper) RoundTrip(r *http.Request) (*http.Response, error) {
 	resp, err := c.Proxied.RoundTrip(r)
 	if err != nil {
 		return nil, err
 	}
 
+	// only dump the HTTP request and response for errors
+	if resp.StatusCode < 400 {
+		return resp, nil
+	}
+
 	requestDump, err := httputil.DumpRequest(r, true)
 	if err != nil {
 		return nil, err